Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tst/testing suite reestructuring #498

Closed
wants to merge 22 commits into from

Conversation

lucasfourier
Copy link
Contributor

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Every testing module is inside the 'tests' folder.

New behavior

Two new folders were introduced: 'unit' and 'integration'. Inside the unit folder, a test module called test_function.py was created. Actually, this is the same that one can find in the tests directory. This is the beginning of the procedure described in #480.

Breaking change

  • Yes
  • No

Additional information

This PR is part of the effort to reorganize the testing suite. Further information can be found here: #480

Gui-FernandesBR and others added 22 commits November 27, 2023 15:06
Adding tests (tst) to the branch naming conventions in the git style page.
ENH: Function Reverse Arithmetic Priority
ENH: Parachute trigger doesn't work if "Apogee" is used instead of "apogee"
MNT: Add __repr__ method to Parachute class
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (afcbf02) 70.80% compared to head (a9ac31c) 71.08%.
Report is 49 commits behind head on master.

Files Patch % Lines
rocketpy/motors/tank.py 71.05% 11 Missing ⚠️
rocketpy/mathutils/function.py 87.50% 4 Missing ⚠️
rocketpy/rocket/parachute.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   70.80%   71.08%   +0.27%     
==========================================
  Files          55       55              
  Lines        9234     9267      +33     
==========================================
+ Hits         6538     6587      +49     
+ Misses       2696     2680      -16     
Flag Coverage Δ
unittests 71.08% <77.63%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR added Tests Regarding Tests and removed Testing suite labels Feb 12, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Regarding Tests
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants